operator: added Ignored status for child objects, do not mark object as failed if it was applied on at least one parent - #2438
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
4a424ce to
e02ad4c
Compare
|
@cubic-ai-dev recheck |
@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
370359b to
40e6990
Compare
40e6990 to
368b06d
Compare
| } | ||
| parentObject := fmt.Sprintf("%s.%s.vmanomaly", cr.Name, cr.Namespace) | ||
| return reconcile.StatusForChildObjects(ctx, rclient, parentObject, []*vmv1.VMAnomalyConfig{childObject}) | ||
| return reconcile.StatusForChildObject(ctx, rclient, parentObject, childObject) |
There was a problem hiding this comment.
We return nil when childObject == nil before we get a chance to set status. Similar to other call sites we should run StatusForChildObjects with pos.configs.All() when its nil
368b06d to
f90a5b3
Compare
|
@cubic-ai-dev |
@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete. |
f90a5b3 to
e20fe4d
Compare
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
e20fe4d to
0f0b4ab
Compare
…as failed if it was applied on at least one parent
0f0b4ab to
8d287cc
Compare
2 participants
fixes #2432