Skip to content

feat(VLE): Remove unit plan - #2346

Merged
breity merged 5 commits into
replace-unit-plan-with-enhanced-step-select-menufrom
remove-unit-plan
Oct 8, 2026
Merged

breity merged 5 commits into
replace-unit-plan-with-enhanced-step-select-menufrom
remove-unit-plan

Conversation

@breity

@breity breity commented Oct 5, 2026

Copy link
Copy Markdown
Member

Changes

  • Removes the Unit Plan or "navigation" view from the VLE.
  • Also updates starting node logic when a unit loads as follows:
    • If requested starting node id isn't active in unit, load unit start node.
    • If requested starting node id is a group (lesson), load group start node.
    • If requested group doesn't have a start node, load unit start node.

Test

  • Make sure all traces of the unit plan, including the Unit Plan button in the StepTools are removed.
  • Make sure the VLE operates as before, including navigation using the StepTools arrow buttons and StepSelect dropdown.
  • Try different starting nodes for a unit by editing the node portion of the url (e.g. http://localhost/preview/unit/1/node1 or http://localhost/preview/unit/1/group100). Make sure the logic outlined above is followed.

breity added 2 commits October 5, 2026 15:04
- If requested starting node id isn't in unit, load unit start node
- If requested starting node id is a group, load group start node
- If group doesn't have a start node, load unit start node
@breity
breity requested a review from hirokiterashima October 5, 2026 23:41
@breity breity self-assigned this Oct 5, 2026
@qltysh

qltysh Bot commented Oct 5, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
src/assets/wise5/vle/vle-parent/vle-parent.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Unrelated to this PR, but I noticed that if you go directly to "group0", it breaks the VLE. I'll write it up in a separate issue.

@breity
breity merged commit 90ff81d into replace-unit-plan-with-enhanced-step-select-menu Oct 8, 2026
3 checks passed
@breity
breity deleted the remove-unit-plan branch October 8, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants