API: move logical geometry to floating point#3032
Draft
ammen99 wants to merge 3 commits into
Draft
Conversation
Contributor
|
I remember there was a bug in firefox when different rounding in this floating poing geometry was causing a lot of crashes when size of the frame did not match the size of the video being decoded into that frame. The difference was really funny like 0.0050 something but that was enough to crash wayland. So it might be a challenge to implement... |
ammen99
force-pushed
the
floating-geometry
branch
from
f4962a1 to
7aeaf97
Compare
ammen99
force-pushed
the
floating-geometry
branch
from
7aeaf97 to
4aa191b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge breaking change, aiming to make it possible to get pixel-perfect layouts on outputs with fractional scaling. The entire codebase (geometries and damage coordinates) have now been moved to floating point numbers. This PR has been largely generated with the help of LLMs and still needs to be reviewed very carefully, thus the draft state.
It is a breaking change for plugins, which will most likely have to adapt, however, aside from the int -> double conversion, very little has changed semantically, so updating plugins should be easy.