Repository navigation
Spectec for binary format of types and instructions - #108
Merged
Merged
Conversation
And struct.new_default_desc. Also update the valiation for struct.new and struct.new_default to require empty descriptors. Add an explanation of expansion to desctype to the validation conventions section and teach SpecTec about the new ExpandDesc relation to avoid errors during rendering.
Update the syntax of func externtypes and func types in the typing context to include exactness. This allows specifying exact function imports and properly typing ref.func as exact for exact imports and defined functions and otherwise as inexact.
Previously the definition of `heaptype` was `... | EXACT typeuse | typeuse`, but this made it impossible to treat the exactness as a variable. Refactor the definition to `... | _HT exact? typeuse` instead. This is similar to how nullability is treated in reference types, except that the `_HT` tag will not be displayed in the rendered spec.
…nctype Update the typing context to store heap types for functions.
tlively
commented
Jul 16, 2026
| | 0x4D x:Btypeidx => DESCRIPTOR (_IDX x) | ||
|
|
||
| grammar Bdesctype : desctype = | ||
| | describestype:Bdescribestype descriptortype:Bdescriptortype ct:Bcomptype => describestype descriptortype ct |
Member
Author
There was a problem hiding this comment.
We probably want some other variable names here. I can use dt1 and dt2, but not dt_1 and dt_2 because dt is already taken by deftype. Any suggestions?
Member
There was a problem hiding this comment.
How about just d_1, d_2? I think d isn't taken globally.
Btw, how about dropping the type suffix on describes/descriptortype? These names are a mouthful, and they aren't really types in their own right anyway, more like modifiers.
Member
Author
There was a problem hiding this comment.
I ended up dropping the type suffix and introducing dedicated metavariables using using some other names in #120 and redoing these changes on top of those.
31 of 51 tasks
…nctype # Conflicts: # document/core/valid/conventions.rst # specification/wasm-latest/1.2-syntax.types.spectec # specification/wasm-latest/2.4-validation.modules.spectec # spectec/test-frontend/TEST.md
# Conflicts: # specification/wasm-latest/2.3-validation.instructions.spectec # spectec/test-frontend/TEST.md
# Conflicts: # spectec/test-frontend/TEST.md
# Conflicts: # specification/wasm-latest/5.3-binary.instructions.spectec
# Conflicts: # document/core/syntax/instructions.rst # document/core/syntax/types.rst # document/core/util/macros.def # document/core/valid/conventions.rst # specification/wasm-latest/1.2-syntax.types.spectec # specification/wasm-latest/2.0-validation.contexts.spectec # specification/wasm-latest/2.1-validation.types.spectec # specification/wasm-latest/2.2-validation.subtyping.spectec # specification/wasm-latest/2.3-validation.instructions.spectec # specification/wasm-latest/2.4-validation.modules.spectec # specification/wasm-latest/4.1-execution.values.spectec # specification/wasm-latest/5.2-binary.types.spectec # specification/wasm-latest/6.2-text.types.spectec # specification/wasm-latest/7.0-soundness.contexts.spectec # specification/wasm-latest/7.1-soundness.configurations.spectec # spectec/test-frontend/TEST.md
# Conflicts: # specification/wasm-latest/2.3-validation.instructions.spectec
# Conflicts: # document/core/syntax/instructions.rst # document/core/syntax/types.rst # document/core/util/macros.def # document/core/valid/conventions.rst # specification/wasm-latest/1.2-syntax.types.spectec # specification/wasm-latest/1.3-syntax.instructions.spectec # specification/wasm-latest/2.0-validation.contexts.spectec # specification/wasm-latest/2.1-validation.types.spectec # specification/wasm-latest/2.2-validation.subtyping.spectec # specification/wasm-latest/2.3-validation.instructions.spectec # specification/wasm-latest/2.4-validation.modules.spectec # specification/wasm-latest/4.1-execution.values.spectec # specification/wasm-latest/4.3-execution.instructions.spectec # specification/wasm-latest/5.2-binary.types.spectec # specification/wasm-latest/6.2-text.types.spectec # spectec/src/backend-prose/gen.ml # spectec/test-frontend/TEST.md
# Conflicts: # spectec/test-frontend/TEST.md
# Conflicts: # spectec/test-frontend/TEST.md
# Conflicts: # specification/wasm-latest/2.3-validation.instructions.spectec # spectec/test-frontend/TEST.md
Also introduce metavariables `dct` for `desctype`, `dcs` for `describes`, and `dcr` for `descriptor`.
Member
Author
|
@rossberg, PTAL. |
rossberg
approved these changes
Oct 25, 2026
Comment on lines
+79
to
+82
| | dcs:Bdescribes dcr:Bdescriptor ct:Bcomptype => dcs dcr ct | ||
| | dcs:Bdescribes ct:Bcomptype => dcs ct | ||
| | dcr:Bdescriptor ct:Bcomptype => dcr ct | ||
| | ct:Bcomptype => ct |
Member
There was a problem hiding this comment.
Can this not be simplified to
Suggested change
| | dcs:Bdescribes dcr:Bdescriptor ct:Bcomptype => dcs dcr ct | |
| | dcs:Bdescribes ct:Bcomptype => dcs ct | |
| | dcr:Bdescriptor ct:Bcomptype => dcr ct | |
| | ct:Bcomptype => ct | |
| | (dcs:Bdescribes)? (dcr:Bdescriptor)? ct:Bcomptype => dcs? dcr? ct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.