Skip to content

fix: Use extattr API to list extended attributes on FreeBSD #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stanleys12 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Use extattr API to list extended attributes on FreeBSD #2926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions plugins/builtin/source/content/providers/file_provider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ namespace hex::plugin::builtin {
#if defined(OS_MACOS) || defined(OS_LINUX)

constexpr static auto getxattrs = [](const char *path, char *list, size_t size) -> ssize_t {
#if defined(OS_LINUX)
#if defined(OS_FREEBSD)
return ::extattr_list_file(path, EXTATTR_NAMESPACE_USER, list, size);
#elif defined(OS_LINUX)
return ::listxattr(path, list, size);
#elif defined(OS_MACOS)
return ::listxattr(path, list, size, 0);
Expand All @@ -180,8 +182,24 @@ namespace hex::plugin::builtin {
std::string xattrList(xattrSize, 0x00);
getxattrs(path.c_str(), xattrList.data(), xattrSize);

#if defined(OS_FREEBSD)
// FreeBSD returns a sequence of names prefixed by a length byte instead of NUL terminated names
std::vector<std::string> xattrs;
for (size_t i = 0; i < xattrList.size();) {
const size_t length = u8(xattrList[i]);
i += 1;
if (i + length > xattrList.size())
break;

xattrs.emplace_back(xattrList.substr(i, length));
i += length;
}
#else
const auto xattrs = wolv::util::splitString(xattrList, std::string(1, 0x00));
#endif

std::string formattedXattrs;
for (const auto &xattr : wolv::util::splitString(xattrList, std::string(1, 0x00))) {
for (const auto &xattr : xattrs) {
if (!xattr.empty())
formattedXattrs += fmt::format("- {}\n", xattr);
}
Expand Down