Phase 1: Add Edit / Suggest / View intent mode scaffolding#77403
Open
adamsilverstein wants to merge 8 commits into
Open
Phase 1: Add Edit / Suggest / View intent mode scaffolding#77403adamsilverstein wants to merge 8 commits into
adamsilverstein wants to merge 8 commits into
Conversation
github-actions
Bot
added
[Package] Editor
adamsilverstein
changed the title
This was referenced Apr 16, 2026
adamsilverstein
force-pushed
the
suggest-mode-phase-1
branch
from
f78a787 to
3ca48fe
Compare
Introduce an `editorIntent` preference orthogonal to the visual/code `editorMode`. The intent captures the user's editing purpose: direct editing (`edit`, default), proposing changes for the author to apply or reject (`suggest`), or a read-only preview (`view`). This is Phase 1 of the Suggest mode effort in #73411. It adds the `setEditorIntent` action, `getEditorIntent` selector, and an Intent switcher menu gated on `editor.notes` post type support. The `view` intent reuses the existing block-editor `isPreviewMode` plumbing to disable editing. Follow-up phases wire capture, diff preview, and apply / reject for the `suggest` intent. Refs #73411
adamsilverstein
force-pushed
the
suggest-mode-phase-1
branch
from
3ca48fe to
4bdfdda
Compare
|
Size Change: +550 B (+0.01%) Total Size: 7.91 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in b49f614. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26054061147
|
adamsilverstein
added
[Type] Enhancement
adamsilverstein
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
requested review from
Mamaduka and
t-hamano
and removed request for
ajitbohra,
fabiankaegy and
juanmaguitar
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +538 B (+0.01%) Total Size: 7.97 MB 📦 View Changed
ℹ️ View Unchanged
|
Document the storage location (preferences store), per-app defaults, and multi-file mirroring requirement so reviewers can trace the intent state without cross-referencing five files. Also explain why unknown intents are silently rejected by setEditorIntent.
This was referenced May 4, 2026
adamsilverstein
force-pushed
the
suggest-mode-phase-1
branch
from
d45e494 to
89c12b6
Compare
Contributor
|
Thanks for all this work. I've been out for a bit of a break, coming back into action. This looks great. there are some small details/questions, I don't necessarily think we have to address them in order to merge this. First question is: you show in all these videos the notes sidebar, but these suggestions appear also in-canvas, like Notes, yes? It also seems like this particular feature is reaching such a level of utility that it is time to increase the prominence of the feature, perhaps move the "Add note" button out of the block toolbar ellipsis to the block toolbar itself. Suggesting of course is a boolean change, anything you make from that point on creates notes, but with that working so easily it feels like manual notes need to as well. The check icon here looks wrong: 
Can use The area in general looks a bit tight: 
The design target barely fits it, and omits the ellipsis: 
What actions are in the ellipsis, do we need it? If not, then perhaps we should show the buttons to accept or dismiss either on its own row, or at the end. And in that case, we could consider converting them from icon buttons to text buttons (compact) instead. Not suggesting here, quite yet, mostly pondering options. The fact that this all works blows my mind, nice work: 
I see two actions in the above, though: the "bold formatting" and the "Applied". Should they be two individual "chat items" in the log? I.e. like this: 
Can we/should we do wysiwyg in the suggestions here? 
If yes I guess the part of the design that forces italic is something we rewind. |
Member
Author
@jasmussen thanks for the review! Suggestion previews are handled separately in #77869. In the latest version the suggestion previews use the avatar colors of the suggesting user. So if your avatar has a green outline, your suggestions appear in green. I broke this effort up into several chunks and used stacked PRs to group the code and keep it reviewable. Unfortunately the GiutHub UI for stacked PRs hasn't been enabled yet, so we don't benefit from that. In the meantime, I will leave a comment on the tracking issue outlining the overall architecture, PRs to review and full feature testing instructions. At a high level:
See #73411 (comment) for a recent update I left on this feature along with testing instructions. |
Contributor
|
Sounds like a good division, and to be clear I wouldn't want to block any of these from landing based on the details I noted, most if not all can be thought of as enhancements, assuming you agree. For me the larger picture, which I feel is important to mention, is that the Notes panel is a tray for anything that relates to your documents. I consider it the place both for manual notes, for suggestions, and honestly even for linting notes (e.g. #76996). The motivation is that multiple separate interfaces for this will simply have you hunting and experimenting to find the right interface, when really all they are, are "notes in the margin of your essay". For me that remains the long term vision. |
Member
Author
Trying this in #78188 |
Member
Author
I'm stripping html for now, Notes don't really support WYSIWYG yet - see #73413 |
8 tasks
This was referenced May 14, 2026
# Conflicts: # packages/editor/CHANGELOG.md
adamsilverstein
added
Backport from WordPress Core
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is the base PR in an 8-PR stack implementing Suggestion mode for the WordPress editor - a Google Docs–style workflow where reviewers can propose changes that the post author can Accept or Reject. Tracked in #73411, with design direction from #73410 and jasmussen's mockups.
Part of #73410
Testing this feature
To exercise the complete Suggest-mode feature (all eight PRs in this stack + structural suggestions #77967→#77979 + inline previews #77869), check out the
try/suggest-mode-combinedintegration branch:The combined branch is testing-only — review still happens on the individual PRs.
Screencasts
Here is the current feature captured 5/4/26. In this view I have two side by side windows open with two separate users editing the same post. The feature works with or without real time collaboration, but I wanted to capture the fully collaborative suggestion experience:
Accepting addition
suggest.add.mp4
Accepting style change
apply.bold.suggestio.mp4
Accepting deletion
suggest.delete.mp4
Rejecting suggested deletion
reject.delete.mp4
Reviewing the code
The code for this feature is split into 5 separate phases to make the reviews smaller. Each PR should be reviewed separately.
Architecture & Yjs readiness
The eventual long-term storage primitive for suggestions is the Yjs
AttributionManagerarriving in Yjs v14 (PR #77005), which attributes CRDT document changes to specific clients - exactly what suggested edits need. However, Yjs v14 is pre-release with an unstable API, and even with Yjs, server-side persistence is still needed for non-RTC users.Rather than block on Yjs, this series builds the full feature now with a comment-meta backend behind a swappable
SuggestionsProviderinterface shaped to match Yjs attribution semantics:attribute-set) - not HTML diffs - so they map directly to whatAttributionManagerwould emit.createSuggestion,updateSuggestion,deleteSuggestion,applySuggestion,rejectSuggestion. Today's implementation reads/writes comment meta; a futureyjs-provider.jscan drop in with the same methods.When #77005 stabilizes, the migration is: implement
yjs-provider.jsagainst the same interface, useAttributionManagerfor live-session attribution, and keep comment-meta as the fallback for users without RTC.The 8 phases
editorIntentpreference (edit/suggest/view), a mode selector in the Options kebab, read-only gating for View intent, keyboard shortcuts, and a "You're suggesting/editing/viewing" snackbar on mode change.editor.BlockEditfilter divertssetAttributesinto a React context so the user sees their edit live but the block-editor store stays at the baseline. The HOC is split so non-Suggest intents only run a singleuseSelect._wp_suggestioncomment meta, theSuggestionsProviderinterface (create/update/delete/apply/reject), and the accept/reject icon buttons in the notes sidebar.edit_postcan apply/reject suggestion notes withoutmoderate_comments, scope-tightened to the suggestion-lifecycle fields. Server-side 64 KB cap on the_wp_suggestionpayload, plus PHP unit tests.SuggestionSummaryrenderer (compact alternative to the full inline diff), per-attributehasAttributeConflictcheck that replaces the post-modified_gmtstaleness compare,setEditorIntentsnackbar wiring, and thewp/suggestionsarchitecture doc +core/editordata reference updates.useSuggestionDecisionhook. Icon-only Apply / Reject buttons in the note header; the note body renders the suggestion summary plus the staleness confirmation dialog. Adds the block-notes and intent-switcher e2e coverage._wp_suggestionnote after a short idle window, and subsequent edits on the same block update the existing note rather than creating a new one.This PR (Phase 1)
editorIntentpreference (edit,suggest,view) orthogonal to the existing visual/codeeditorModesetEditorIntentaction +getEditorIntentselector in the editor store<IntentSwitcher>component: Edit / Suggest / View menu in the Options kebab, gated oneditor.notespost type support⌥⇧⌘Z/X/C, orCtrl+Alt+Shift+…on Windows/Linux)viewintent reuses the existingisPreviewModeblock-editor setting for read-only rendering - no new machineryWhat's NOT in this PR
_wp_suggestioncomment meta and accept/reject provider (Phase 3: Add suggestion diff preview, Apply, and Reject #77405)Phase 1 test plan
contenteditable="false")npm run test:unit -- packages/editor/src/store/test/actions.js --testNamePattern=setEditorIntentnpm run test:e2e -- test/e2e/specs/editor/various/editor-intent-switcher.spec.js📋 Tracking issue: #73411
AI Use
I prompted Claude to write this code and reviewed and tested it manually.
🗺️ PR Stack Navigation
_wp_suggestionmeta, provider, sidebar actions📋 Tracking issue: #73411