-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[components] Draggable: Migrate clone wrapper to wp compat overlay slot #78183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
7768e43
Draggable: Migrate clone wrapper to wp compat overlay slot
ciampo d66e4ce
Draggable: Storybook: render docs-page stories in iframes
ciampo 3c09678
Draggable: Storybook: polish cross-document fallback playground story
ciampo a53d116
CHANGELOG: Restore entries dropped during rebase
ciampo b2713a2
Storybook: Fix popover-with-slotfill cross-iframe collision boundary
ciampo fa37c7d
Draggable: Storybook: refresh AppendElementToOwnerDocument JSDoc
ciampo 66e1e7a
Draggable: CHANGELOG: Call out default-mode in-flow ancestor change
ciampo c218161
Draggable: Add e2e regression for chip-inside-compat-slot
ciampo 25d07c4
Storybook: Trim file-level docblocks on playground stories
ciampo 55b0e5e
Storybook: popover-with-slotfill story: use public @wordpress/ui API
ciampo ef62906
Storybook: draggable cross-doc story: load components styles via Stor…
ciampo 5835688
Storybook: Move cross-document fallback story under "Debug fixtures"
ciampo 54e5070
Storybook: Drop redundant `parameters.sourceLink` from playground sto…
ciampo 479051b
Draggable: Migrate styles from SCSS to a CSS module
ciampo 888f2ef
Storybook: Simplify cross-document fallback story with StyleProvider
ciampo 3798ccb
Draggable: CHANGELOG: Move entry to Unreleased and slim it down
ciampo 9ebae4b
Draggable: Trim verbose inline code comments
ciampo db5e5c8
@wordpress/ui CHANGELOG: Move #78183 entry to Unreleased
ciampo 3ebeca5
Draggable: Keep physical `left` for the invisible drag image
ciampo 12225ff
@wordpress/ui CHANGELOG: Trim #78183 entry
ciampo dfbf2d2
@wordpress/ui: Restore unrelated tsconfig change
ciampo 7bce5a9
Storybook: Drop redundant story-name overrides
ciampo a5fb5c1
Draggable: Keep body cursor class global
ciampo d0276b7
Draggable: Guard class arrays against the Jest CSS-module mock
ciampo cb9b980
Draggable: Address minor self-review nits
ciampo 76a277c
Storybook: Group compat-slot fixtures under Debug fixtures
ciampo 6500cbd
Draggable: Use kebab-case for CSS module class names
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| @use "@wordpress/base-styles/z-index" as *; | ||
|
|
||
| .invisible-drag-image { | ||
| position: fixed; | ||
| /* stylelint-disable-next-line plugin/use-logical-properties-and-values -- Offscreen drag-image stand-in; flipping with writing direction has no benefit. */ | ||
| left: -1000px; | ||
| height: 50px; | ||
| width: 50px; | ||
| } | ||
|
|
||
| .clone { | ||
| position: fixed; | ||
| padding: 0; // Should match clonePadding variable. | ||
| background: transparent; | ||
| pointer-events: none; | ||
| // Stacking fallback for when the clone is not routed into the | ||
| // `@wordpress/ui` compat overlay slot. | ||
| z-index: z-index(".components-draggable__clone"); | ||
| } | ||
|
|
||
| // Keep this selector global so external code that toggles the same | ||
| // body class (e.g. block-editor keyboard drag) gets the same cursor. | ||
| :global(body.is-dragging-components-draggable) { | ||
| cursor: move; /* Fallback for IE/Edge < 14 */ | ||
| cursor: grabbing !important; | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.