Automated Testing: Fix and use built-in mechanism for flagging unused disables#78313
Open
aduth wants to merge 3 commits into
Open
Automated Testing: Fix and use built-in mechanism for flagging unused disables#78313aduth wants to merge 3 commits into
aduth wants to merge 3 commits into
Conversation
aduth
added
the
[Type] Automated Testing
…gnore patterns" This reverts commit 73031e9.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.96 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue where unused ESLint disable comments are not being correctly flagged, and fixes existing issues.
This may have regressed as part of the recent ESLint upgrade in #76654. Strangely, we had the rule configured to catch issues as an error, but they were being surfaced as a warning.
Why?
Unused disables add unnecessary noise to the code and potential confusion.
How?
Uses
linterOptions.reportUnusedDisableDirectives, which is now a built-in option.Testing Instructions
npm run lint:jsshould pass.Use of AI Tools
No AI used.