Add contrast checker for pseudo-state color panels#78333
Open
dhruvikpatel18 wants to merge 1 commit into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78305
What?
Adds contrast-ratio checking to all interactive pseudo-state color panels (:hover, :focus, :focus-visible, :active) in the block inspector.
When a user sets a low-contrast color combination for a pseudo-state, a warning notice now appears, the same notice already shown for the default state.
Also fixes a false-positive warning that could appear when the user was editing the default state and physically hovered the block in the canvas while the inspector was open.
Why?
PR #76491 added support for styling blocks per interactive pseudo-state, which is great for theming. However, the existing contrast checker (BlockColorContrastChecker) works by reading colors via window.getComputedStyle on the live canvas DOM element.
In the default state this works correctly: the computed styles reflect the block's current colors.
In a pseudo-state (:hover, :focus, etc.) the canvas element is always in its resting state. The pseudo-state CSS rules never apply to the DOM unless the user physically hovers/focuses the element, which they won't be doing while typing in the color picker. So getComputedStyle silently returns the default-state colors and the contrast check is effectively skipped, exactly the bug described issue.
The false-positive case was the inverse: if the user happened to hover the canvas while on the default panel, the DOM checker would briefly read the hover-state CSS and emit a spurious warning.
Testing Instructions
Screenshots or screencast
Screen.Recording.2026-05-15.at.4.17.29.PM.mov