List View: Expose block visibility label to assistive technology#78640
Open
ciampo wants to merge 1 commit into
Open
List View: Expose block visibility label to assistive technology#78640ciampo wants to merge 1 commit into
ciampo wants to merge 1 commit into
Conversation
Address the TODO left in `block-select-button.js` by PR #78411. The TODO claimed `visibilityLabel` was sighted-hover-only because the tooltip trigger is `aria-hidden`. In practice, the same label is already computed in the parent `ListViewBlock` as `blockVisibilityDescription` and included in the hidden `AriaReferencedText` that the row's `<a>` references via `aria-describedby`, so screen readers do announce it. This change: - Computes the visibility label once in `ListViewBlock` and passes it down to `ListViewBlockSelectButton` as a `visibilityLabel` prop, removing the duplicated `useSelect` + `getBlockVisibilityLabel` call in the child. - Replaces the TODO with a comment explaining where assistive technology exposure happens, to avoid future readers re-adding the same warning. The visual tooltip on the (decorative) visibility icon is preserved unchanged.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 8.04 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses the inline
TODOleft inblock-select-button.jsby #78411, claimingvisibilityLabelis sighted-hover-only.Why?
The TODO is misleading. The tooltip trigger is
aria-hidden, but the parentListViewBlockalready includes the same label in a hiddenAriaReferencedTextthat the row's<a>references viaaria-describedby— so screen readers do announce it.Pre-existing AT exposure path
The row's
<a>already wiresaria-describedby={ descriptionId }, so the visibility label is announced as part of the row description.How?
ListViewBlockand pass it down as avisibilityLabelprop.useSelectfield +getBlockVisibilityLabelcall inListViewBlockSelectButton.AriaReferencedText.No visual change.
Testing Instructions
Testing Instructions for Keyboard / Screen reader
Screenshots or screencast
No visual change. N/A.
Use of AI Tools
This PR was authored with assistance from Cursor (Claude). All changes were reviewed by a human before being committed.