dynamic tracing compiler temporary API block#308
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables the JSON in-memory dynamic tracing result API (update_dtrace_result_buffer) by commenting out its public declaration and implementation.
Changes:
- Commented out the
json/nlohmann/json.hppinclude from the public dtrace header. - Commented out the
update_dtrace_result_bufferAPI declaration and its implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/cpp/dtrace/dtrace.h |
Removes the JSON dependency from the public header by commenting out the include and API declaration. |
src/cpp/dtrace/dtrace.cpp |
Disables the JSON in-memory result API by commenting out the full function implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: advanaik <AdvaitHemant.Naik@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xuhz
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Temporary block the unused
update_dtrace_result_bufferAPI for dtrace header file refactoringBug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Xilinx/XRT#9876
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
cmake build testcase
Documentation impact (if any)
NA