Repository navigation
Add Student 4 post-commit endpoint tests to CI - #205
Merged
Merged
Conversation
Run two backend/API endpoint functions over HTTP against the live Compose slice: create/read an activity, and search with QUERY /activity. The compose job starts the shared reference service for location lookup, publishes a results table to the step summary and uploads the JUnit and Markdown evidence. The module skips without STUDENT4_ENDPOINT_BASE_URL so offline pytest runs are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 2 requires post-commit testing of two backend/API endpoint functions per student through
student-4-ci.yml. Student 4 had no such step; this adds it, following the Student 3 pattern.POST /activitythenGET /activity/{id}, plus an unknown-category400and an unknown-id404.QUERY /activitywith text, location, category, price and party-size filters, plus a non-matching search and an unsupported-category400.student-4/tests/endpoint/and run over HTTP against the built images on127.0.0.1:18008. They clean up the activity they create, and skip whenSTUDENT4_ENDPOINT_BASE_URLis unset, so offlinepytest student-4/testsis unchanged.shared-databaseandshared-backend(--no-deps) because activities resolve country/city names through the shared reference service. It then writes a results table to the step summary and uploadsstudent-4-endpoint-test-evidence(JUnit XML + Markdown).tests/endpointadded to the strict mypy configuration and CI type-check step.Local verification
pytest student-4/tests/endpoint -v, 6 passedruff check student-4,ruff format --check student-4: passtests/endpoint: no issuespytest student-4/tests -q: pass (endpoint tests skipped offline).github/tests/test_workflow_self_triggers.py+tests/ci: 70 passedThe CI run on this PR is the first run of the new workflow steps.
🤖 Generated with Claude Code