modify login response to enable codegen to generate header based client - #7
Merged
Conversation
|
@abhiandthetruth did you have time to look at https://github.com/nicolas-chaulet/openapi-typescript-codegen? We handle 204 status codes as I was running into issues with generated types assuming success response would always be defined |
Owner
Author
|
Hey no, have not checked that out. Will do in some time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen we are using does not support 204 as response code due to a weird bug. So we need to use 200 but no content so that it generates a client service which returns a header.
Have raised an MR with fix: ferdikoomen/openapi-typescript-codegen#1965