Repository navigation
Fix #5467: Handle underscores in parenthesized pnpm lockfile dependency values - #5471
Open
shreyaagrawal788-dotcom wants to merge 1 commit into
Open
shreyaagrawal788-dotcom wants to merge 1 commit into
shreyaagrawal788-dotcom wants to merge 1 commit into
Conversation
…file dependency values Signed-off-by: Shreya Agrawal <shreyaagrawal788@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5467
Summary of Changes
BaseNpmHandler.update_dependencies_by_purlinsrc/packagedcode/npm.pyto only split on_when'('is not present in the dependency metadata. This preventsValueErrorcrashes and truncated requirements on pnpm v6/v9 lockfiles containing underscores inside parenthesized peer dependencies (e.g.,7.3.0(@types/babel__core@7.20.5)) orpatch_hashsuffixes (e.g.,20.17.7(patch_hash=...)).test_update_dependencies_by_purl_pnpm_underscoresintests/packagedcode/test_npm.pycovering both parenthesized v6/v9 values and underscore-separated v5 peer dependency values.Tasks
Run tests locally to check for errors.