feat: Implement post-deletion node shrink logic across all ART node types#47
Closed
Bhuviiiii-prog wants to merge 32 commits into
Closed
feat: Implement post-deletion node shrink logic across all ART node types#47Bhuviiiii-prog wants to merge 32 commits into
Bhuviiiii-prog wants to merge 32 commits into
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ert, merged conflicts from angelo
…ndependent and other small changes
This was referenced Jun 22, 2026
Member
|
closed in favour of #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements shrink logic for all node types in the ART delete path
Context
After each deletion, nodes with too few children are rebuilt at the next smaller nodetype
Description
Ran insert/search/delete scenarios across node transitions ([Node256 → Node48 → Node16 → Node4] and reverse)
Changes
Updated
removechild()to handle all different node types and addedshouldshrink()andshrink()functionsTests
Ran a test validating full growth and shrink lifecycle
cmd/radFS/arttest/main.goAll checks passed with expected node type transitions at every threshold and root correctly returning nil after the final deletion as intended
Additional info
This PR is built on top of PR #41 that implements growth