PIN-19784 | Update PNS spec to support region field for Cross Region Peering#2008
Open
saritathakur0 wants to merge 12 commits into
Open
PIN-19784 | Update PNS spec to support region field for Cross Region Peering#2008saritathakur0 wants to merge 12 commits into
saritathakur0 wants to merge 12 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niraj-nangliya-acquia
approved these changes
Jun 23, 2026
TestBase::getPathMethodCodeFromSpec() was iterating over all keys in each path object (including 'servers' keys added in 4c6a038) and accessing $endpoint['operationId'] without checking if the key was an HTTP method. Added a guard to skip non-method keys and entries without operationId. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Restore root-level 'servers' key to acquia-spec.json (removed when path-level servers were introduced in 4c6a038) - Add missing endpoints back to spec: /v3/environments/{environmentId} (operationId: environment_by_id) and /codebases/{codebaseId}/sites (codebases:sites-list) which were dropped in the spec update - Fix timestamp formats: restore .000Z suffix on backup/environment timestamps (2012-05-15T12:00:00Z -> 2012-05-15T12:00:00.000Z) and SSH key created_at (+00:00 -> .000Z) to match test expectations - Update from/to parameter examples to full ISO 8601 format - Update testApiCommandDefinitionRequestBody expected usage string to include new 'region' field in vpc_peers (added in 4c6a038) - Update testBuildApiCommandConfiguresResponsesServersAndHelp to use api:codebases:sites-list as the pre-release command example Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
=========================================
Coverage 92.49% 92.49%
Complexity 1991 1991
=========================================
Files 123 123
Lines 7232 7232
=========================================
Hits 6689 6689
Misses 543 543 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2008/acli.phar |
The GET /codebases/{codebaseId}/applications endpoint (operationId:
codebase_applications, x-cli-name: codebases:applications:list) was
accidentally dropped during the spec update in 4c6a038. Restoring it
allows testBuildApiCommandConfiguresResponsesServersAndHelp to use
the original command name without any test code change.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The following endpoint groups were removed and are now restored: - site-instances:* (13 endpoints) - database, backups, domains, files, find, dissociate - sites:* (6 endpoints) - CRUD, list, environments-list - codebases:environments-list/find, codebases:create - environments:sites-list, environments:site-instances:create - environments-v3:update, environments-v3:clear-caches - subscriptions:sites-list Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CX API Spec PR - https://github.com/acquia/cx-api-spec/pull/429
Manual Review - https://acquia.atlassian.net/browse/PIN-19784?focusedCommentId=10281626