[Proposal] Update IPNs URL#347
Open
akiko-pusu wants to merge 4 commits into
Open
Conversation
In Rails edge, deprecate `starts_with?` and `ends_with?` for String core extensions. Ref rails/rails#39152.
Contributor
|
Not sure if it's a temporary issue, but starting today calls to Updating the URL to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for all!
This pull request is not a bug fix, but a proposal.
Reason
Now Paypal recommends the use of new endpoints based on 'ipnpb.paypal.com'.
Ref:
What happens in this situation?
We can still use the URL
https://www.sandbox.paypal.com/cgi-bin/webscrandhttps://www.paypal.com/cgi-bin/webscrwithout any difference in terms of API features.But following the document that I wrote above,
www.paypal.comreturns the response under the dynamic IP address.If some requirements exist such as restriction for the source/destination IP address, ''ipnpb.paypal.com'' based URL is better.
Of course, we can change the URL by ourselves by overwriting the variable like this:
Other proposals
If this PR is not acceptable, I think updating README to introduce how to customize the URL like above.
NOTE:
Before submitting this pull request, I posted the one to fix the CI failure.
I wish either one would be of help.