Skip to content

Fix: Drawer heading focus (Fixes: #400) #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joe-replin wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix: Drawer heading focus (Fixes: #400) #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8f5c17
Move text into aria-label
joe-replin Jul 5, 2023
ba7711b
Merge branch 'master' into issue/400
swashbuck May 27, 2026
e21f8dd
Revert template
swashbuck May 27, 2026
99c3c23
Change focusFirst to defer false
swashbuck May 27, 2026
160c4f0
Fix: Prevent duplicate drawer heading announcement in screen readers
swashbuck May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/views/drawerView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,10 @@ class DrawerView extends Backbone.View {
Adapt.trigger('drawer:opened');

this.$el.addClass('anim-show-before');
// focus on first tabbable element in drawer
a11y.focusFirst(this.$el, { defer: true });
// focus the drawer dialog itself so its accessible name (aria-labelledby)
// is announced once on open; focusing the heading element directly caused
// a duplicate announcement (label + focused element)
a11y.focus(this.$el, { defer: false });
await transitionNextFrame();
this.$el.addClass('anim-show-after');
await transitionsEnded(this.$el);
Expand Down
2 changes: 1 addition & 1 deletion templates/drawer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="drawer__inner">

<span id="drawer-heading" class="aria-label">{{_globals._accessibility._ariaLabels.drawer}}</span>
<span id="drawer-heading" class="aria-label" aria-hidden="true">{{_globals._accessibility._ariaLabels.drawer}}</span>

<div class="drawer__toolbar">

Expand Down