Conversation
displayTitle mirrors title in the editor, but the schema only names the DisplayTitle editor - what that editor name means is hardcoded in the tool resolving it, so the relationship can't be reused for any other pair of fields. Add _adapt.linkedTo to say it directly. Additive: _backboneForms is unchanged, so nothing consuming it is affected, and no runtime behaviour changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #875
Update
_adapt.linkedTo: "title"todisplayTitle, stating the relationship theDisplayTitleeditor name currently only implies._backboneFormsis left untouched, so anything consuming it behaves exactly as before — this is purely additive, and an annotation either way, so there's no runtime change and existing content is unaffected. The same key is proposed for the large/small image pair in adaptlearning/adapt-contrib-graphic#132, which is what makes it a reusable vocabulary rather than a second special case.Testing
schema/content.schema.jsonstill parses and content renders as before — the added keyword is inert at runtime.