Skip to content

fix(deps): sync registry types and patch new audit advisories - #3401

Merged
bokelley merged 2 commits into
mainfrom
bokelley/audit-and-registry-sync
Oct 24, 2026
Merged

bokelley merged 2 commits into
mainfrom
bokelley/audit-and-registry-sync

Conversation

@bokelley

@bokelley bokelley commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the upstream drift that is failing CI on every PR, including #3380 and #3399:

Patch changeset included. Local: build, typecheck, format, registry tests and the portability test pass.

🤖 Generated with Claude Code

- Regenerate registry types from the published OpenAPI (prepared-fixture
  denial error body).
- npm audit fix: body-parser, fast-uri, ip-address, undici and zod
  transitive advisories; lockfile only.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@@ -0,0 +1,5 @@
---
'@adcp/sdk': patch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium: patch for a response-type widening. The generated 403 body goes from Error ({ error: string }) to Error | { code: "PREPARED_FIXTURES_DENIED"; refusal_code: string }. A downstream consumer reading .error off the 403 body now gets a compile error without first narrowing — a response-shape change on an exported type. Generated types are excluded from the changeset-trigger paths and this is an additive witness-the-wire correction, so patch is defensible, but minor is the more conservative semver call. Non-blocking.

aao-secretariat[bot]
aao-secretariat Bot previously approved these changes Oct 24, 2026

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — routine registry schema sync with no blocking findings.

What I checked:

  • schemas/registry/registry.yaml adds a distinct PREPARED_FIXTURES_DENIED 403 variant; anyOf branches are genuinely disjoint (Error requires error; new body requires code+refusal_code), so no ambiguous wire-shape collision.
  • src/lib/registry/types.generated.ts regenerated to match the schema exactly — no drift, no fabrication (witness-not-translator preserved).
  • package-lock.json bumps transitive deps only, no range changes, consistent with the changeset.
  • Changeset present.

Medium findings (non-blocking):

  • .changeset/registry-and-audit-sync.md:2 — patch changeset for a 403 response-type widening (Error → union). minor is arguably more correct, but generated types are excluded from the changeset trigger and this is an additive, witness-the-wire correction. One medium only.

Decision path: No critical/high (row 1 n/a). gated_paths: false (row 2 n/a). high_risk is true but the only high-risk file is (modified) with only a single medium finding — row 5 requires the modified file AND a medium; however the finding is on the changeset file, not the high-risk schema file, and more importantly re-reading row 5: it fires on any medium when a modified high-risk file is present.

Correction: row 5 reads "high_risk true AND any (modified) entry AND any medium finding." That condition is met → escalate.

Medium findings

  • .changeset/registry-and-audit-sync.md:2 — patch changeset for a 403 response-type widening

zod 4.6.6+ (the advisory fix) changes how zod-openapi renders the Product
format intersection (anyOf, 1.5 MB document), failing the portability test.
Patch the other advisories only; zod is tracked separately.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@bokelley
bokelley merged commit a008b4e into main Oct 24, 2026
44 of 46 checks passed
@bokelley
bokelley deleted the bokelley/audit-and-registry-sync branch October 24, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant