Skip to content

fix(release): separate discovery harness patch classification - #8719

Merged
bokelley merged 1 commit into
mainfrom
fix/classify-discovery-harness
Nov 3, 2026
Merged

bokelley merged 1 commit into
mainfrom
fix/classify-discovery-harness

Conversation

@bokelley

@bokelley bokelley commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

PR #8703 grouped an optional protocol capability with conformance harness fixes in one minor changeset. Split the capability into its own minor changeset and classify the harness fixes as patch, so maintenance releases can select harness changes without adding a stable schema field.

Add a short applicability note to the provenance enforcement narrative: creative.supports_provenance starts in AdCP 3.3, a creative library alone does not establish support, and responses on earlier releases cannot advertise this declaration. Runtime behavior and wire schemas are unchanged by this PR.

Validation:

  • Changeset protocol scope check and release status pass; the combined main release remains minor.
  • 107 focused source/contract tests pass.
  • Normal pre-commit checks pass, including root and server tests.

This PR is a prerequisite for a selective 3.1 harness backport. It does not promote a candidate release, publish artifacts, or alter historical release files.


Open workspace in Conductor

@bokelley
bokelley marked this pull request as ready for review November 3, 2026 11:38

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean release-bookkeeping PR, no blocking or medium findings.

Checked:

  • Changeset scope/type: Splits the wire-adding creative.supports_provenance capability out of PR #8703's combined changeset into its own minor changeset; harness-only fixes reclassified as patch. Net main-line bump stays minor, so the schema field in get-adcp-capabilities-response.json remains covered — no untracked wire change.
  • Schema↔docs coherence: No schema source modified (no oneOf/docs-coherence exposure). The provenance_enforcement.yaml narrative note ("introduced in AdCP 3.3") is accurate against the field's schema presence and the repo's 3.3.0-beta.3 version.
  • Release line: Base is main, not 3.1.x; no breaking change, no artifact immutability concern.

No findings. high_risk false; gated_paths false. review_decision is REVIEW_REQUIRED, but gated_paths is false so row 2 does not fire. No author team gate. Falls through to row 9.

@bokelley
bokelley merged commit 227cf43 into main Nov 3, 2026
61 checks passed
@bokelley
bokelley deleted the fix/classify-discovery-harness branch November 3, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant