Repository navigation
fix(release): separate discovery harness patch classification - #8719
Merged
Merged
Conversation
bokelley
marked this pull request as ready for review
November 3, 2026 11:38
Contributor
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean release-bookkeeping PR, no blocking or medium findings.
Checked:
- Changeset scope/type: Splits the wire-adding
creative.supports_provenancecapability out of PR #8703's combined changeset into its own minor changeset; harness-only fixes reclassified as patch. Net main-line bump stays minor, so the schema field inget-adcp-capabilities-response.jsonremains covered — no untracked wire change. - Schema↔docs coherence: No schema source modified (no
oneOf/docs-coherence exposure). Theprovenance_enforcement.yamlnarrative note ("introduced in AdCP 3.3") is accurate against the field's schema presence and the repo's 3.3.0-beta.3 version. - Release line: Base is
main, not3.1.x; no breaking change, no artifact immutability concern.
No findings. high_risk false; gated_paths false. review_decision is REVIEW_REQUIRED, but gated_paths is false so row 2 does not fire. No author team gate. Falls through to row 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8703 grouped an optional protocol capability with conformance harness fixes in one minor changeset. Split the capability into its own minor changeset and classify the harness fixes as patch, so maintenance releases can select harness changes without adding a stable schema field.
Add a short applicability note to the provenance enforcement narrative:
creative.supports_provenancestarts in AdCP 3.3, a creative library alone does not establish support, and responses on earlier releases cannot advertise this declaration. Runtime behavior and wire schemas are unchanged by this PR.Validation:
This PR is a prerequisite for a selective 3.1 harness backport. It does not promote a candidate release, publish artifacts, or alter historical release files.
Open workspace in Conductor