Skip to content

Promo flicker fix by resizing lenis after Gnav loads#6233

Open
bandana147 wants to merge 3 commits into
stagefrom
gnav-promo
Open

Promo flicker fix by resizing lenis after Gnav loads#6233
bandana147 wants to merge 3 commits into
stagefrom
gnav-promo

Conversation

@bandana147

@bandana147 bandana147 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@bandana147
bandana147 requested a review from a team June 30, 2026 05:42
@aem-code-sync

aem-code-sync Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@bandana147 bandana147 closed this Jul 3, 2026
@bandana147 bandana147 reopened this Jul 9, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@prativas22

prativas22 commented Jul 13, 2026

Copy link
Copy Markdown

While verifying the issue fix, observed that the flickering issue persisted.
https://main--upp--adobecom.aem.page/homepage/drafts/blaishram/redesign-demo-promo-minimized?fedsbranch=gnav-promo&milolibs=gnav-promo

flickerIssue.mp4

@DKos95 DKos95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've observed some inconsistencies with the border-radius of the router-marquee/header when scrolling the page and reloading it, is this expected behaviour?

Screen.Recording.2026-07-16.at.13.30.51-compressed.mp4

@bandana147

Copy link
Copy Markdown
Contributor Author

I've observed some inconsistencies with the border-radius of the router-marquee/header when scrolling the page and reloading it, is this expected behaviour?

Screen.Recording.2026-07-16.at.13.30.51-compressed.mp4

@DKos95 Please retest again. This was a separate issue for which a fix was added.

@DKos95

DKos95 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@DKos95 Please retest again. This was a separate issue for which a fix was added.

Seems some cache was the issue, the issue is no longer coming up, however I did notice one more thing I would like cleared up before approving, seems that on mobile the border radius is unset sooner than on desktop, before it reaches top, is this expected?

Screenshot 2026-07-16 at 15 47 45

@overmyheadandbody overmyheadandbody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok, but @DKos95 has a valid comment on mobile experience, which should be addressed

@bandana147

bandana147 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@DKos95 Please retest again. This was a separate issue for which a fix was added.

Seems some cache was the issue, the issue is no longer coming up, however I did notice one more thing I would like cleared up before approving, seems that on mobile the border radius is unset sooner than on desktop, before it reaches top, is this expected?

Screenshot 2026-07-16 at 15 47 45

We remove the border radius once Gnav has the scrolled state, added a fix to reduce the scrolled state starting earlier on mobile. Thank you for looking into this.

@overmyheadandbody overmyheadandbody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Router Marquee block now jumps when the promo scrolling concludes

Promo.jump.mov

@Snehayt

Snehayt commented Jul 20, 2026

Copy link
Copy Markdown

Validated promo with parameters : fedsbranch=gnav-promo&milolibs=gnav-promo

https://main--upp--adobecom.aem.page/homepage/drafts/blaishram/redesign-demo?fedsbranch=gnav-promo&milolibs=gnav-promo

  1. Flicker issue is now resolved
  2. The content overlap issue with promo when scrolled is resolved
image image
20260720-1619-45.5241382.mp4

cc: @bandana147

@spadmasa spadmasa added the verified PR has been E2E tested by a reviewer label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants