Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions libs/blocks/table/table.css
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,10 @@
margin: 0;
}

.table.preserve-columns .section-row-title {
grid-column: auto !important;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can selector be adjusted so we can avoid !important ?

}

.table:not(.merch) .row .section-head-title,
.table:not(.merch) .row .section-row-title {
border-right: 1px solid var(--border-color);
Expand All @@ -701,12 +705,25 @@
display: block;
}

.table.preserve-columns .col-heading.col-1,
.table.preserve-columns .row-highlight .col-highlight.col-1 {
display: flex !important;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

}

.table .section-head .col:not(.section-head-title),
.table:not(.merch) .col-heading.col-1,
.table:not(.merch) .row-highlight .col-highlight.col-1:not(:only-child) {
display: none;
}

.table.preserve-columns .row-heading .col-heading:first-child {
border-top-left-radius: var(--border-radius);
}

.table.preserve-columns .row-heading .col-heading:last-child {
border-top-left-radius: 0;
}

.table:not(.merch) .row-highlight:has(> :only-child) {
grid-template-columns: repeat(auto-fit, 100%);
}
Expand Down
15 changes: 14 additions & 1 deletion libs/blocks/table/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,9 @@ function applyStylesBasedOnScreenSize(table, originTable) {
const deviceBySize = defineDeviceByScreenSize();

const setRowStyle = () => {
if (table.classList.contains('preserve-columns')) {
return;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit;

Suggested change
if (table.classList.contains('preserve-columns')) {
return;
}
if (table.classList.contains('preserve-columns')) return;

if (isMerch) return;
const sectionRow = Array.from(table.getElementsByClassName('section-row'));
if (sectionRow.length) {
Expand Down Expand Up @@ -614,7 +617,10 @@ function applyStylesBasedOnScreenSize(table, originTable) {
}

removeClones();
if (deviceBySize === 'MOBILE' || (isMerch && deviceBySize === 'TABLET')) {
if (
!table.classList.contains('preserve-columns')
&& (deviceBySize === 'MOBILE' || (isMerch && deviceBySize === 'TABLET'))
) {
mobileRenderer();
} else {
table.querySelectorAll('.hide-mobile, .left-round, .right-round').forEach((col) => { col.classList.remove('hide-mobile', 'left-round', 'right-round'); });
Expand Down Expand Up @@ -670,6 +676,13 @@ export default function init(el) {
expandSection = handleSection(sectionParams);
});

const firstRow = el.querySelector('.row-1');
const columnCount = firstRow?.children.length || 0;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
const firstRow = el.querySelector('.row-1');
const columnCount = firstRow?.children.length || 0;
const columnCount = el.querySelector('.row-1')?.children.length || 0;


if (columnCount <= 2) {
el.classList.add('preserve-columns');
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
if (columnCount <= 2) {
el.classList.add('preserve-columns');
}
if (columnCount <= 2) el.classList.add('preserve-columns');


handleHighlight(el);
handleStickyHeader(el);
if (isMerch) formatMerchTable(el);
Expand Down
10 changes: 10 additions & 0 deletions test/blocks/table/mocks/two-column-table.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<div class="table">
<div>
<div><p>Feature</p></div>
<div><p>Details</p></div>
</div>
<div>
<div><p>Row 2 label</p></div>
<div><p>Row 2 value</p></div>
</div>
</div>
16 changes: 16 additions & 0 deletions test/blocks/table/table.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ describe('table and tablemetadata', () => {
expect(table.querySelector('.row-heading')).to.exist;
});

it('does not add preserve-columns class to tables with more than two columns', () => {
expect(table.classList.contains('preserve-columns')).to.be.false;
});

it('adds preserve-columns class to a table with two or fewer columns', async () => {
const html = await readFile({ path: './mocks/two-column-table.html' });
const container = document.createElement('div');
container.innerHTML = html;
document.body.appendChild(container);

const twoColTable = container.querySelector('.table');
init(twoColTable);
expect(twoColTable.classList.contains('preserve-columns')).to.be.true;
container.remove();
});

it('expand icon event by mouse click', () => {
const expandIcon = table.querySelector('.icon.expand');
expect(expandIcon.ariaExpanded).to.be.equal('true');
Expand Down
Loading