MWPW-199499 [Lingo] IMS Country Code#6261
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Requesting changes on one item:
- akamaiLocale param reorder breaks MEP country spoofing for logged-in users and anyone with the country cookie set (QA/internal). Spoke with Joel and he's ok with dropping this — i.e., the akamaiLocale param would again take precedence over the country cookie . That's the only change I'm blocking on; should be quick to drop.
return countryParam || akamaiParam || cookieCountry || imsCountry || geoCountry;
Not blocking, but raising for discussion:
- IMS lands on the critical path for MEP and mep-lingo. resolveDetectedMarketCountry runs eagerly for MEP countryIP and mep-lingo, so adding loadIms()+getProfile() there blocks LCP for signed-in users when a geo-targeted MEP experience or a Lingo fragment is in the first section. There were
discussions about reconciling after LCP, but unlike pricing, neither MEP nor mep-lingo can. They resolve country once to pick which variant/fragment loads. Since MWPW-199499 is a pricing requirement on a shared resolver, would it be possible to scope the IMS lookup to the pricing path so they stay geo-only?
@vhargrave @sukamat @JasonHowellSlavin
|
For # 1 - Sounds good. We can revisit this once you are back from PTO. For # 2 - For the short term, I think it should be OK to scope it to just price and see if can solve this for MEP in the later phases. That said, AFAIK, there are few pages that use mep-lingo on ACOM. Is there any possibility of mismatches happening on those pages with MEP not honoring IMS whereas MAS honoring it? (cc: @vhargrave) |
vhargrave
left a comment
There was a problem hiding this comment.
Asides from the comment from @markpadbe looks pretty good to me.
Blocking the PR though because we discussed this in a meeting today and folks want a bit more time to discuss the performance impact and if we're willing to take that for the benefit.
An info should follow soon. 🙌
Adding the IMS country code merch pricing hierarchy chain. This is the proposed new order:
?country> country cookie > IMS country code >?akamaiLocale> IP Geo > Page defaultResolves: MWPW-199499
Test URLs: