Skip to content

Enabling spacebar in editable targets inside Gnav #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bandana147 wants to merge 3 commits into
base: stage
Choose a base branch
from
+4 −2
Open

Enabling spacebar in editable targets inside Gnav #6279

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef96748
Enabling spacebar in editable targets
bandana147 Jul 12, 2026
255e199
Excluding bc placeholder from background css
bandana147 Jul 13, 2026
13906a1
Adding button tag under bc-placeholder selector
bandana147 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/blocks/global-navigation/global-navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
text-decoration: none;
}

.global-navigation button:not(.feds-client-desktop-apps button, .feds-client-plans-cta button) {
.global-navigation button:not(.feds-client-desktop-apps button, .feds-client-plans-cta button, .feds-bc-wrapper) {
Comment thread
bandana147 marked this conversation as resolved.
Outdated
background: none;
cursor: pointer;
}
Expand Down
4 changes: 3 additions & 1 deletion libs/blocks/global-navigation/utilities/keyboard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,9 @@ class KeyboardNavigation {
}
case 'Enter':
case 'Space': {
if (e.target.closest(selectors.searchField) || e.target.closest('.feds-client-search')) return;
if (e.target.closest(selectors.searchField)
|| e.target.closest('.feds-client-search')
|| e.target.matches('input, textarea, select, [contenteditable]')) return;
e.stopPropagation();
e.preventDefault();
e.target.click();
Expand Down
Loading