[MWPW-199341] Reduce motion effect when applied not seen working on carousel#6295
Open
SamSawant876 wants to merge 2 commits into
Open
[MWPW-199341] Reduce motion effect when applied not seen working on carousel#6295SamSawant876 wants to merge 2 commits into
SamSawant876 wants to merge 2 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Expected video behaviour:
Reduce motion on: Videos do not auto-play on arrow navigation, user must click play.
User clicks play: Video plays while its slide remains sufficiently visible in the carousel viewport.
User swipes / navigates away (either direction): Video's slide is no longer sufficiently visible and is paused.
Navigation blocked at a disable-circular-nav boundary: A playing video that's actually out of view still gets paused, even though the active slide didn't change.
Slide returns to view: Video stays paused, it does not auto-resume. User must click play again.
Test URLs:
Before: https://main--da-cc--adobecom.aem.live/products/firefly/features/image-to-video
After: https://main--da-cc--adobecom.aem.live/products/firefly/features/image-to-video?milolibs=mwpw-199341-firefly-carousal-fix
Resolves: Resolves: MWPW-199341