MWPW-200785 [Lingo] Stop reading the international cookie in sign-in region resolution#6298
Open
vhargrave wants to merge 1 commit into
Open
MWPW-200785 [Lingo] Stop reading the international cookie in sign-in region resolution#6298vhargrave wants to merge 1 commit into
vhargrave wants to merge 1 commit into
Conversation
…region resolution
getLingoRegion({ useGeoLocation: true }) no longer consults the
`international` cookie/sessionStorage; the sign-in region resolves from the
user's geo only, matching the Akamai redirect and webps's implementation.
Split off from MWPW-200345 (#6268) — the acomLocale/acomCountry split is
shelved per Shane Do; this is the small, low-risk half we want to land now.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #6268 (MWPW-200345). Per Shane Do,
acomCountryis not a CCHome requirement yet (Akamai-only shipped), so theacomLocale/acomCountrysplit is shelved. This PR carries only the small, low-risk half we want to land now.Resolves: MWPW-200785
What changes
getLingoRegion({ useGeoLocation: true })no longer consultssessionStorage.international/ theinternationalcookie. On the sign-in path the Lingo region now resolves from the user's geo (physical location) only — matching the Akamai redirect and webps's implementation.Why: under Lingo the
internationalcookie holds only the language (not a region), so it is no longer meaningful for sign-in region resolution. Resolving from geo makes the sign-in path emit the same region as the Akamai redirect, giving CCH/Adobe Home one consistent contract.Scope / non-changes
getLingoRegionpath used by MEP/content is unchanged (still the selected-marketcountrycookie).acomLocale=<region-prefix>as on stage today). TheacomCountrysplit lives in the shelved MWPW-200345 [Lingo] Split Adobe Home redirect into acomLocale + acomCountry #6268.Tests
test/utils/utils.test.js—getLingoRegionwithuseGeoLocationnow ignores theinternationalcookie and resolves from geo (both the "diverges" and "no region" cases); theloadImsredirect test asserts geo wins over a divergentinternationalcookie.test/blocks/susi-light-login/susi-light-login.test.js— sign-in widget locale follows geo, ignoring theinternationaland market cookies.npm test: 3691 passed; the only failure is the knownfetchAndProcessPlainHtml with MEPgnav network flake (fails identically on cleanstage, unrelated to this change).Test URLs
Steps to test:
set your international cookie to lu_fr using the region picker in the footer for example and notice how it has no impact on the after url anymore. You'll be taken to https://www.stage.adobe.com/home?acomLocale=ch_fr instead of https://www.stage.adobe.com/home?acomLocale=lu_fr