Skip to content

Remove HTML elements for empty Figma JSON values#220

Draft
saurabhsircar11 wants to merge 1 commit into
adobecom:devfrom
saurabhsircar11:remove-elements-no-values
Draft

Remove HTML elements for empty Figma JSON values#220
saurabhsircar11 wants to merge 1 commit into
adobecom:devfrom
saurabhsircar11:remove-elements-no-values

Conversation

@saurabhsircar11

@saurabhsircar11 saurabhsircar11 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Description

Centralizes empty-value handling across all block renderers: a shared isEmptyValue predicate ('', null, false, [], {}), central .to-remove flagging in handleComponents with a cascade for emptied parent wrappers (never structural divs), and guards in blocks that build DOM directly (table, logo-gallery, carousel). Includes review fixes: null action-area guard, blank product-lockup filtering, and hero-marquee action-area unflagging.

<img width="1512" height="633" alt="Screenshot 2026-07-13 at 10 52 51 AM" src="https://github.com/user-attachments/assets/ba9f13a0-4482-4bda-95c0-97b04827232d" />

Related Issue

N/A

Test URLs

@aem-code-sync

aem-code-sync Bot commented Jul 13, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 / Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ / Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@saurabhsircar11
saurabhsircar11 marked this pull request as draft July 15, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants