Update supported file formats#845
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
| "application/msexcel", | ||
| "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", | ||
| "application/x-tika-msworks-spreadsheet", | ||
| "application/vnd.adobe.form.fillsign", |
There was a problem hiding this comment.
@Ruchika4
Do we want "application/vnd.adobe.form.fillsign" in no-adobe-design?
There was a problem hiding this comment.
Hi @vipu0303 , requirements called out .ai, .indd and .psd adobe files only hence they were only removed for no-adobe-design from already existing list of allowed file types. I will talk to Andy to get confirmation and we can handle that in a separate PR if needed. Please let me know if any concern.
|
Verified in the branch. All looks fine. Test results are in the task |
Summary
Restricts accepted file formats per verb to match the defined support matrix, rather than allowing all file types for most conversion verbs.
Changes
unitylibs/core/workflow/workflow-acrobat/limits.jsonallowed-filetypes-no-adobe-design— all formats fromallowed-filetypes-allexcept PSD, AI, and INDDallowed-filetypes-psd-only—image/vnd.adobe.photoshoponlyallowed-filetypes-ai-only—application/illustratoronlyallowed-filetypes-indd-only—application/x-indesignonlyunitylibs/core/workflow/workflow-acrobat/action-binder.jspsd-to-pdf,ai-to-pdf,indd-to-pdf→ each restricted to their own format only (previously accepted all file types)jpg-to-pdf,png-to-pdf,heic-to-pdf,image-to-pdf,bmp-to-pdf,gif-to-pdf,tiff-to-pdf,word-to-pdf,excel-to-pdf,ppt-to-pdf→ switched toallowed-filetypes-no-adobe-design+allowed-filetypes-heic(removes PSD/AI/INDD acceptance, adds HEIC where missing)createpdf(Convert PDF) — unchanged, continues to accept all formatstest/core/workflow/workflow-acrobat/action-binder.test.jsimage-to-pdf verbs onboardingtest block to match new configurationTesting
npm test— 846 passed, 0 failedpsd-to-pdf— only PSD should be acceptedai-to-pdf— only AI should be acceptedindd-to-pdf— only INDD should be acceptedjpg-to-pdf) — should be rejectedword-to-pdf,jpg-to-pdf, etc. — should be acceptedcreatepdf(Convert PDF) — all formats should still be acceptedResolves: MWPW-200291
Test URLs:
Note: DC PRs for reference adobecom/dc-frictionless#62 and adobecom/da-dc#142