Skip to content

Remove outdated Twitter driver#161

Closed
ThisIsMissEm wants to merge 5 commits into
adonisjs:5.xfrom
ThisIsMissEm:remove-twitter-driver
Closed

Remove outdated Twitter driver#161
ThisIsMissEm wants to merge 5 commits into
adonisjs:5.xfrom
ThisIsMissEm:remove-twitter-driver

Conversation

@ThisIsMissEm

@ThisIsMissEm ThisIsMissEm commented May 7, 2025

Copy link
Copy Markdown

This appears to no longer work following the rebranding of Twitter to X and various other API changes — all the URLs in the driver are incorrect for authenticating against the X service.

There's some discussion in this thread: https://discord.com/channels/423256550564691970/1369735537056809102

🔗 Linked issue

none

❓ Type of change

This removes a driver that as far as I can tell would no longer be usable anyway.

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Twitter was rebranded to X, changed it's API and consequently this driver would no longer work (based on their documentation)

📝 Checklist

This appears to no longer work following the rebranding of Twitter to X and various other API changes — all the URLs in the driver are incorrect for authenticating against the X service.
@thetutlage

Copy link
Copy Markdown
Member

Can we add a driver for X?

@ThisIsMissEm

Copy link
Copy Markdown
Author

@thetutlage I don't have an X account and wouldn't do free work for the world's richest man who also believes people like me shouldn't exist, so you wouldn't see such from me.

But I'm sure someone could write an Ally driver for X in user-land if they really want it.

tbh, maybe it'd be a good idea to move all drivers to separate packages? Allowing them to independently evolve apart from Ally as a whole?

@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request

@github-actions github-actions Bot added the Stale label May 30, 2025
@thetutlage thetutlage removed the Stale label Jun 2, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request

@github-actions github-actions Bot added the Stale label Jun 24, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been automatically closed because it has been inactive for more than 4 weeks. Please reopen if you still intend to submit this pull request

@github-actions github-actions Bot closed this Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants