Repository navigation
[Go] Reject generated flyweight group headers whose blockLength is below the fixed fields - #1188
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…low the fixed fields. WrapForDecode now panics when a group with entries has a blockLength smaller than the fields present at the acting version, so Next cannot hand out entries aliasing the same bytes. Constant fields and composite members newer than the acting version must stay excluded.
slachiewicz
force-pushed
the
go-flyweight-group-block-length-check
branch
from
November 19, 2026 21:03
dbba049 to
08b783a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated Go flyweight group
WrapForDecodestored the wire blockLength and count unchecked, so a header with a zero blockLength letNextandForEachhand out any number of entries aliasing the same bytes. The generator now emits a check that panics when the group has entries and its blockLength is below the fixed fields present at the acting version, computed per schema version so composite members added later and constant fields do not count.Part of #969.
Verified:
TestGroupBlockLengthMustCoverFieldsAtActingVersionfails on master (three expected panics missing) and passes here; checkstyle,:sbe-tool:test,verifyJavaIrCodecsInSync,:sbe-samples:checkandgocodemakepass.