Refonte - classe Cotisations#2084
Open
vgreb wants to merge 1 commit into
Open
Conversation
Collaborator
vgreb
commented
Jan 5, 2026
vgreb
commented
- Utilisation des repository Ting pour la accès bdd
- Utilisation du model MembershipFee à la place de tableau.
vgreb
force-pushed
the
refacto/class-cotisation
branch
3 times, most recently
from
c02c559 to
93b9710
Compare
vgreb
force-pushed
the
refacto/class-cotisation
branch
from
93b9710 to
dabb142
Compare
vgreb
force-pushed
the
refacto/class-cotisation
branch
from
dabb142 to
44a1bfb
Compare
vgreb
force-pushed
the
refacto/class-cotisation
branch
3 times, most recently
from
3fea1d2 to
afb6181
Compare
vgreb
force-pushed
the
refacto/class-cotisation
branch
2 times, most recently
from
4b3649f to
3abce8d
Compare
Collaborator
Author
|
resolves #2227 |
vgreb
force-pushed
the
refacto/class-cotisation
branch
2 times, most recently
from
d1eb0a8 to
1993051
Compare
stakovicz
reviewed
May 11, 2026
Contributor
stakovicz
left a comment
stakovicz
left a comment
There was a problem hiding this comment.
Beau travail, le découpage en service est bien plus cohérent, bravo !
Pas facile à relire 🥵
vgreb
force-pushed
the
refacto/class-cotisation
branch
from
1993051 to
f33390f
Compare
stakovicz
approved these changes
May 18, 2026
vgreb
force-pushed
the
refacto/class-cotisation
branch
2 times, most recently
from
af2abb5 to
73759cb
Compare
vgreb
force-pushed
the
refacto/class-cotisation
branch
from
73759cb to
5975511
Compare
Mopolo
reviewed
May 27, 2026
Comment on lines
+66
to
+67
| $sql .= ' type_reglement= :paymentType,'; | ||
| $sql .= ' informations_reglement=:paymentInfos'; |
Contributor
There was a problem hiding this comment.
Suggested change
| $sql .= ' type_reglement= :paymentType,'; | |
| $sql .= ' informations_reglement=:paymentInfos'; | |
| $sql .= ' type_reglement = :paymentType,'; | |
| $sql .= ' informations_reglement = :paymentInfos'; |
Comment on lines
+81
to
+82
| $sql .= ' type_personne=:userType '; | ||
| $sql .= ' AND id_personne=:userId '; |
Contributor
There was a problem hiding this comment.
Je nitpick
Suggested change
| $sql .= ' type_personne=:userType '; | |
| $sql .= ' AND id_personne=:userId '; | |
| $sql .= ' type_personne = :userType '; | |
| $sql .= ' AND id_personne = :userId '; |
Comment on lines
+103
to
+104
| $sql .= ' type_personne=:userType '; | ||
| $sql .= ' AND id_personne=:userId '; |
Contributor
There was a problem hiding this comment.
Suggested change
| $sql .= ' type_personne=:userType '; | |
| $sql .= ' AND id_personne=:userId '; | |
| $sql .= ' type_personne = :userType '; | |
| $sql .= ' AND id_personne = :userId '; |
| use AppBundle\Compta\BankAccount\BankAccountFactory; | ||
| use AppBundle\MembershipFee\Model\Repository\MembershipFeeRepository; | ||
|
|
||
| final class MembershipFeeInvoicePdfGenerator |
Contributor
There was a problem hiding this comment.
Suggestion pour éviter la répétition dans le constructeur.
Suggested change
| final class MembershipFeeInvoicePdfGenerator | |
| final readonly class MembershipFeeInvoicePdfGenerator |
| use AppBundle\MembershipFee\Model\Repository\MembershipFeeRepository; | ||
| use Webmozart\Assert\Assert; | ||
|
|
||
| final class MembershipFeeMailer |
Contributor
There was a problem hiding this comment.
Pareil ici, y'a peut-être une règle rector pour ça si ça se trouve ?
Suggested change
| final class MembershipFeeMailer | |
| final readonly class MembershipFeeMailer |
| ->setInvoiceDate(new \DateTimeImmutable()) | ||
| ; | ||
| $this->membershipFeeRepository->save($membershipFee); | ||
| return true; |
Contributor
There was a problem hiding this comment.
C'est une reprise de l'existant je suppose ? Ça semble pas très utile vu que ça ne retourne jamais false.
Si quelque chose casse y'aura une exception de toute façon.
Comment on lines
+21
to
+28
| * @param $idPersonne Identifiant de la personne | ||
| * @param $montant Montant de la cotisation (en euros) | ||
| * @param $typeReglement Type de règlement (espèces, chèque, virement) | ||
| * @param $informationsReglement Informations concernant le règlement (numéro de chèque, de virement etc.) | ||
| * @param $dateDebut Date de début de la cotisation | ||
| * @param $dateFin Date de fin de la cotisation | ||
| * @param $commentaires Commentaires concernant la cotisation | ||
| * @param $referenceClient Référence client à mentionner sur la facture |
Contributor
There was a problem hiding this comment.
On n'y est pas encore mais PHPStan va pas aimer ces annotations 😄
Le fait qu'il y ai juste le nom sans le type va poser problème.
Une suggestion : mettre un paramètre par ligne dans la méthode, avec les commentaires dedans.
Un truc de ce genre :
function foo(
// lorem
Bar $bar,
// ipsum
int $fiz,
)
Et comme ça on évite le doublon des noms de paramètres.
| return ['type' => (int) $memberType, 'id' => (int) $memberId]; | ||
| } | ||
|
|
||
| public function validerReglementEnLigne(string $cmd, float $total, string $autorisation, string $transaction): mixed |
Contributor
There was a problem hiding this comment.
Le retour n'est pas du tout utilisé donc on peut s'en passer.
Suggested change
| public function validerReglementEnLigne(string $cmd, float $total, string $autorisation, string $transaction): mixed | |
| public function validerReglementEnLigne(string $cmd, float $total, string $autorisation, string $transaction): void |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.