Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main release gate exposed an intermittent MCP reconnect timeout: the SSE fixture flushed HTTP headers before registering its response channel, allowing an immediate initialize POST to lose its response. Failed-test cleanup could also race WaitGroup.Wait against a newly starting handler's Add.
Register the fixture response channel before announcing readiness and let httptest.Server.Close wait for handlers after cancellation. Apply the same ordering to the progress fixture. Production MCP code is unchanged.
Validation: MCP SSE/session tests pass with
go test -race ./pkg/mcp/service -run 'TestManager(SSE|GatewaySession|ListGatewaySessions)' -count=100. Full release gates and Linux CI run before v0.7.0 tagging.Clean candidate
cfc7f16c6805897560752ef5df519d895aeff9edalso passesmake verify-release,make smoke-release, the immutable independent consumer gate and the paired independent consumer gate (Go 1.26.3). Tagging still waits for PR and main Linux CI.