Memory allocation intrinsics#163
Closed
JTrenerry wants to merge 10 commits into
Closed
Conversation
b-paul
reviewed
Jun 23, 2026
| | "@calloc" | "@_calloc" | "@zmalloc" -> Calloc | ||
| | "@alloca" | "@_alloca" -> AllocStack | ||
| | "@free" | "@#free" | "@_free" -> Free | ||
| | _ -> failwith "Unreachable") |
Collaborator
There was a problem hiding this comment.
Could this return an option and have replace_call match on the result of this function? that way there isn't duplication of function name strings (though they are also duplicated in lang/stmt.ml so perhaps a better solution exists).
b-paul
reviewed
Jun 23, 2026
| [ | ||
| TypeError | ||
| { text = "Wrong type of arg in " ^ to_string intrin_call }; | ||
| ] |
Collaborator
There was a problem hiding this comment.
could you put this if-then-else into a function, since it's quite big and repeated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds memory allocation intrinsics.
I am unsure what to do with free_alloca, should this be called on the exit of a proc when it contains an alloca?
Also unsure what names should be accepted to be transformed.
Also unsure why the attribs are not updating for the calls.