Repository navigation
Preserve controller ACL across firmware upgrades and recover missing access - #46
Merged
Merged
Conversation
aiden0rchad
force-pushed
the
codex/fix-45-acl-preservation
branch
from
October 20, 2026 20:47
bfefe0d to
2e2cc7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firmware upgrades that keep settings retain the controller's rpcd login but discard its manually installed ACL, leaving adopted devices permanently denied. Register the ACL in
/etc/sysupgrade.confduring adoption and refresh, and remove that entry during rollback and unadoption. Backup-list edits are atomic, preserve permissions and unrelated entries, and avoid duplicates.Restore a missing ACL through the existing refresh action only when the saved SSH host key matches before administrator authentication. Verify a fresh controller session, device MAC, and capabilities afterward. Managed and monitor-only scopes remain distinct. Add filesystem and SSH/ubus regression tests, update the router-change disclosures, and document recovery for existing devices.
Local validation:
go test -count=1 ./...go test -race -count=1 ./internal/adoption ./internal/daemon -run 'Test(ACL|RefreshACL|Adopt|Unadopt|Cleanup)'go vet ./...npm --prefix ui test— 563 tests passed in the isolated checkoutnpm --prefix ui run build./tools/secret-scan.sh --treeRelated to #45. Keep the issue open pending reporter confirmation of recovery and preservation across a real firmware upgrade. No physical firmware upgrade was performed for this change.
Rebased onto
mainat f8d21d8 after #47. Full CI and documentation checks pass on 2e2cc7e, including the full race suite, browser tests, dependency scans, reproducible release archives, container backup/restore, and multi-platform image build. The ACL patch is unchanged by the rebase. The full Go suite and 563 UI unit tests also passed locally after rebasing.