Repository navigation
Keep else-if storage operations inside their branch - #29642
Merged
Merged
Conversation
mohammadfawaz
added
馃悰 bug
IGI-111
approved these changes
Oct 1, 2026
IGI-111
left a comment
IGI-111
left a comment
Collaborator
There was a problem hiding this comment.
More evidence we should have a mux operator imo
mohammadfawaz
force-pushed
the
codex/fix-veria-41-else-if-storage
branch
from
October 2, 2026 13:41
3b4fbf0 to
eaa6dcc
Compare
mohammadfawaz
enabled auto-merge (squash)
October 2, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage operations in an
else ifcondition could run before the outer branch was evaluated. A skipped condition could therefore pop a storage vector, swap an element, or trigger an out-of-bounds assertion.Keep the generated statements inside the enclosing
elsebranch. Operations run in source order when the condition is reached and do not run when an earlier branch is taken. The command syntax and project setup stay unchanged.Addresses VERIA-41:
https://veria.dev/dashboard/findings/b_UvDabyuY-aduAQnOazk