fix: serialize parsing for shared command CLIs - #3243
Closed
patrick-andstar wants to merge 1 commit into
Closed
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serialize parsing and help metadata construction for a shared command CLI.
Fixes #2595
Motivation
Built-in commands are long-lived and AnnotatedCommandImpl caches their CLI descriptor. The middleware CLI parser sorts and iterates that descriptor's argument list during parsing. Concurrent HTTP API requests for the same command can therefore throw ConcurrentModificationException before command execution begins.
Changes
Tests
mvn -V -ntp -pl core -Dtest=ProcessImplConcurrencyTest test(2 tests, 0 failures, 0 errors)Notes
The lock is scoped to parsing a single shared command descriptor. It does not serialize command execution, instrumentation, or result delivery.
Duplicate Check
Checked open pull requests using: 2595, ConcurrentModificationException, and monitor. No open pull request fixes concurrent parsing of the shared command CLI.