fix: send a valid WebSocket close code for missing agents - #3244
Open
patrick-andstar wants to merge 1 commit into
Open
fix: send a valid WebSocket close code for missing agents#3244patrick-andstar wants to merge 1 commit into
patrick-andstar wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Send a valid private-use WebSocket close code when a tunnel client requests an unknown Arthas agent.
Related to #3187
Motivation
TunnelSocketFrameHandler constructs a CloseWebSocketFrame with status code 2000 when the requested agent is absent. Netty rejects 2000 under RFC 6455, so the client receives an internal exception instead of the intended missing-agent close frame and error message.
Changes
Tests
mvn -V -ntp -pl tunnel-server -am -Dtest=TunnelSocketFrameHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test(1 test, 0 failures, 0 errors)Notes
This change preserves the existing missing-agent behavior. It does not register an absent agent or claim to resolve unrelated tunnel registration failures.
Duplicate Check
Checked open pull requests for #3187 and WebSocket close-code terms. No pull request addressing this invalid close status was found.