fix: preserve background marker in batch mode - #3245
Closed
patrick-andstar wants to merge 1 commit into
Closed
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep a trailing background marker after the plaintext output pipeline generated by the Telnet batch client.
Fixes #3223
Motivation
TelnetConsole.batchModeRun() appends
| plaintextto every batch command. For a command ending in&, appending the pipeline after the marker makes&no longer the final token, so the server does not run the command in the background.Changes
| plaintextbefore a trailing background marker instead of after it.&.Tests
mvn -V -ntp -pl client -am -Dtest=TelnetConsoleBatchModeTest -Dsurefire.failIfNoSpecifiedTests=false test(4 tests, 0 failures, 0 errors)Duplicate Check
Checked the first 100 open pull requests for batchModeRun, plaintext, and the Issue wording. No matching open pull request was found.