src/adldap/CMakeLists.txt: Improve the libsasl2 check#454
Open
artyom-poptsov wants to merge 1 commit into
Open
src/adldap/CMakeLists.txt: Improve the libsasl2 check#454artyom-poptsov wants to merge 1 commit into
artyom-poptsov wants to merge 1 commit into
Conversation
Without "libsasl2" installed the compilation process always fails with an error due to missing "sasl/sasl.h". However, in the current situation cmake configuration script does not produce a clear message that "libsasl2" is missing and keeps going, producing a proper Makefile. This patch fixes such behavior by adding a proper prefix parameter for "pkg_check_modules" in the "libsasl2" check which makes the configuration script to bail out earlier with a clear error. * src/adldap/CMakeLists.txt: Add prefix parameter for "pkg_check_modules" in the "libsasl2" check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without "libsasl2" installed the compilation process always fails with an error due to missing "sasl/sasl.h". However, in the current situation cmake configuration script does not produce a clear message that "libsasl2" is missing and keeps going, producing a proper Makefile. This patch fixes such behavior by adding a proper prefix parameter for "pkg_check_modules" in the "libsasl2" check which makes the configuration script to bail out earlier with a clear error.