fix(agent-ui): keep app alive on GPU-process crash in GPU-less envs#1801
Draft
github-actions[bot] wants to merge 1 commit into
Draft
fix(agent-ui): keep app alive on GPU-process crash in GPU-less envs#1801github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
A GPU-process crash routed through the child-process-gone safety net was treated as fatal, killing the whole Electron app in GPU-less environments (Windows Sandbox, headless VMs). GPU crashes are recoverable — Chromium relaunches the GPU process and falls back to software rendering — so log them and let Chromium recover instead of exiting. Other child-process crashes stay fatal. Closes #1800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agent UI desktop app crashed on launch in any GPU-less environment (Windows Sandbox, headless VMs, some RDP sessions): the Electron GPU child process crashes, and GAIA's
child-process-gonesafety net treated that as fatal — showing "GAIA crashed" and exiting before the window ever rendered. GPU-process crashes are recoverable (Chromium relaunches the GPU process and, after repeated failures, falls back to software rendering), so the app should ride them out, not die. After this change a GPU crash is logged and ignored; the app keeps running and renders via software fallback. Non-GPU child-process crashes stay fatal, so unrelated failures are still surfaced.Closes #1800
Test plan
cd tests/electron && npm test -- test_main_error_handling.jspasses (GPU crash → no exit; non-GPU crash → still fatal)python util/lint.py --allpasses