-
Notifications
You must be signed in to change notification settings - Fork 4
ScaleOutDellPlugin and ScaleOutAristaPlugin #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunnyhe2
wants to merge
13
commits into
development
Choose a base branch
from
sunny_switch_port
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a6446ed
scaleout switch port
sunnyhe2 83a2773
rename
sunnyhe2 27a45ab
arista typo
sunnyhe2 83acfd5
cleanup
sunnyhe2 a086778
union add
sunnyhe2 365c143
Merge branch 'development' into sunny_switch_port
alexandraBara 44ce6a1
Merge branch 'development' into sunny_switch_port
alexandraBara 0162d14
mini-refactor
sunnyhe2 ddef498
CMD align
sunnyhe2 d02ebef
execution status NOT_RAN
sunnyhe2 82dffc8
hardened collector/analyzer+OS discovery for switch+utest
alexandraBara 7828618
added missing file
alexandraBara 5c2a5aa
worked html_view into all plugins
alexandraBara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ############################################################################### | ||
| from .scale_out_arista import ScaleOutAristaPlugin | ||
| from .scale_out_dell import ScaleOutDellPlugin | ||
|
|
||
| __all__ = ["ScaleOutAristaPlugin", "ScaleOutDellPlugin"] |
28 changes: 28 additions & 0 deletions
28
nodescraper/plugins/inband/switch/scale_out_arista/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ############################################################################### | ||
| from .scale_out_arista_plugin import ScaleOutAristaPlugin | ||
|
|
||
| __all__ = ["ScaleOutAristaPlugin"] |
44 changes: 44 additions & 0 deletions
44
nodescraper/plugins/inband/switch/scale_out_arista/analyzer_args.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ############################################################################### | ||
| from typing import List, Optional | ||
|
|
||
| from pydantic import Field | ||
|
|
||
| from nodescraper.models import AnalyzerArgs | ||
|
|
||
|
|
||
| class ScaleOutAristaAnalyzerArgs(AnalyzerArgs): | ||
| """Arguments for the Arista switch analyzer.""" | ||
|
|
||
| analysis_ports: Optional[List[str]] = Field( | ||
| default=None, | ||
| description=( | ||
| "Restrict per-port analysis to the given ports. Ports specified in" | ||
| "the form 'S/P' (e.g. ['1/1', '2/1', '17/1']) " | ||
| "When omitted, every port present in the data is " | ||
| "analyzed, Independent of any collection-time port filter." | ||
| ), | ||
| ) |
45 changes: 45 additions & 0 deletions
45
nodescraper/plugins/inband/switch/scale_out_arista/collector_args.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ############################################################################### | ||
| from typing import List, Optional | ||
|
|
||
| from pydantic import Field | ||
|
|
||
| from nodescraper.models import CollectorArgs | ||
|
|
||
|
|
||
| class ScaleOutAristaCollectorArgs(CollectorArgs): | ||
| """Arguments for the Arista switch collector.""" | ||
|
|
||
| collection_ports: Optional[List[str]] = Field( | ||
| default=None, | ||
| description=( | ||
| "Restrict collection to the given port(s). Each list element " | ||
| "triggers one command invocation" | ||
| "Accepted forms include '1/1', '1/1-8/1'" | ||
| "(e.g. ['1/1-3/1', '17/1-17/1']). " | ||
| "When omitted, commands run once against all ports." | ||
| ), | ||
| ) |
94 changes: 94 additions & 0 deletions
94
nodescraper/plugins/inband/switch/scale_out_arista/scale_out_arista_analyzer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ############################################################################### | ||
|
|
||
| import re | ||
| from typing import Any, ClassVar | ||
|
|
||
| from nodescraper.interfaces import DataAnalyzer | ||
|
|
||
| from ..switch_analyzer_base import SwitchAnalyzerBase | ||
| from .analyzer_args import ScaleOutAristaAnalyzerArgs | ||
| from .scaleoutaristadata import ScaleOutAristaDataModel | ||
|
|
||
|
|
||
| class ScaleOutAristaAnalyzer( | ||
| SwitchAnalyzerBase[ScaleOutAristaDataModel], | ||
| DataAnalyzer[ScaleOutAristaDataModel, ScaleOutAristaAnalyzerArgs], | ||
| ): | ||
| """Check Arista switch data for errors and warnings. | ||
|
|
||
| Walks every model in the collected :class:`ScaleOutAristaDataModel` and checks | ||
| each ``error_fields`` / ``warning_fields`` ClassVar against an optional | ||
| ``ports`` filter. | ||
| """ | ||
|
|
||
| VENDOR_NAME: ClassVar[str] = "Arista" | ||
| DATA_MODEL = ScaleOutAristaDataModel | ||
|
|
||
| # ``M/S`` port identifier (e.g. ``1/1``), with optional ``Ethernet`` | ||
| # prefix so both filter tokens (``"1/1"``) and live port names | ||
| # (``"Ethernet1/1"``) normalize to the same canonical key. | ||
| PORT_NAME_RE: ClassVar[re.Pattern] = re.compile(r"^(?:Ethernet)?(\d+)/(\d+)$", re.IGNORECASE) | ||
|
sunnyhe2 marked this conversation as resolved.
Outdated
|
||
| PORT_FORMAT_HINT: ClassVar[str] = "expected form 'M/S'" | ||
|
|
||
| def _walk_system(self, switch_data: ScaleOutAristaDataModel) -> list[dict[str, Any]]: | ||
| findings: list[dict[str, Any]] = [] | ||
|
|
||
| if switch_data.system_env is None: | ||
| return findings | ||
|
|
||
| findings.extend( | ||
| self._check_model( | ||
| switch_data.system_env, | ||
| context={"section": "system_env"}, | ||
| ) | ||
| ) | ||
|
|
||
| for idx, psu in enumerate(switch_data.system_env.power_supply_slots or []): | ||
| findings.extend( | ||
| self._check_model( | ||
| psu, | ||
| context={ | ||
| "section": "power_supply_slots", | ||
| "index": idx, | ||
| "label": psu.label, | ||
| }, | ||
| ) | ||
| ) | ||
|
|
||
| for idx, fan in enumerate(switch_data.system_env.fan_tray_slots or []): | ||
| findings.extend( | ||
| self._check_model( | ||
| fan, | ||
| context={ | ||
| "section": "fan_tray_slots", | ||
| "index": idx, | ||
| "label": fan.label, | ||
| }, | ||
| ) | ||
| ) | ||
|
|
||
| return findings | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.