Repository navigation
Fix Command stubtest errors - #788
Merged
Merged
Conversation
Owner
|
Sure you can put it in this PR if it's easier. Also, given that I had never heard about |
Contributor
Author
FWIW; It's used by typeshed itself, and we also use it at NumPy, for example, so it's pretty decent stuff.
Yea that's indeed what I was planning on after fixing the errors :) |
jorenham
force-pushed
the
typing/Command-stubtest-fixes
branch
from
July 22, 2026 20:57
7949238 to
43d8c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #787, here's the next batch of stubtest fixes. This time for the
sh.Commandclass.before:
after:
There's one place where I deviated from runtime, which is for the return type of
__class_getitem__. At runtime it directly returnscls, but it's better to have it return atypes.GenericAliasso that e.g.print(Command[str])will be printed asCommand[str]. Currently it also allows nonsensical expressions likeCommand[str][str][str], which won't be possible anymore if we'dd change that to return aGenericAlias.Do you want me to take care of that as well? And if so, should I put it in here, or in a separate PR?