Repository navigation
Run stubtest and pyrefly coverage check in CI (and tox) - #794
Merged
Merged
Conversation
Contributor
Author
|
CI failure seems unrelated: |
Owner
Yeah, let's do it 👍 Thank you! This is awesome. People have had gripes about sh typing in modern IDEs for a long time, and your work here really buttons it up. |
stubtest and pyrefly coverage check in CI (and tox)
amoffat
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised in #791:
... and so it shall be done.
Oh and while we're at it, it might also be a good idea to ensure 100% type coverage (i.e. ensure that everything in the public API is annotated). For that we could use
pyrefly coverage check(docs; but don't mind the "experimental" status, which doesn't really apply anymore,and I think I'll go ahead and open a PR to remove that right nowand I opened a PR for that: facebook/pyrefly#4269):When I remove a random annotation in the stubs, here's what you'll see:
And FWIW; we're also using it in numpy and scipy-stubs, and it has been very helpful, and was able to catch things that stubtest didn't catch.
So if you want I could also add that as well?