Repository navigation
Synchronize SIGINT delivery in test_general_signal - #799
Open
ryanchou1994 wants to merge 2 commits into
Open
ryanchou1994 wants to merge 2 commits into
ryanchou1994 wants to merge 2 commits into
Conversation
Wait for the signal handler to update the child before checking its final output. Bound the child wait and the parent process without using a lock in the handler. Refs amoffat#784.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_general_signalcurrently relies on two-second sleeps in the child. If the output callback is delayed after reading3, the child can print4before SIGINT arrives, breaking the expected0, 1, 2, 3, 42, 43output.Wait for the handler's existing
i = 42update before printing the final two values. The wait uses a monotonic deadline and a short sleep; the handler only assigns the variable. A parent timeout also bounds the test if the child stops making progress. The change is confined to this test.Validation:
uv.lock.Refs #784.