Repository navigation
fix(asyncio): make RunningCommand hashable for asyncio.gather (#800) - #802
Open
ansh-rohilla wants to merge 1 commit into
Open
ansh-rohilla wants to merge 1 commit into
ansh-rohilla wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunningCommanddefines__eq__(return id(self) == id(other)), but did not define__hash__. In Python 3, overriding__eq__without explicitly defining__hash__implicitly sets__hash__ = None, making instances unhashable.Because
RunningCommandimplements__await__, instances are commonly passed toasyncio.gather(*commands). However,asyncio.gatheruses an internal dictionary lookup (arg not in arg_to_fut), which raised:Following the Python data model convention for classes with identity equality, this sets
__hash__ = object.__hash__onRunningCommand.Changes
__hash__ = object.__hash__toRunningCommandinsrc/sh/__init__.py.test_async_gatherintests/sh_test.pyverifying hashability, set/dict lookups, and concurrent completion withasyncio.gather.Closes #800