Skip to content

Add devicetrees for ad7405 And ADuM7701 - #3588

Merged
nunojsa merged 2 commits into
mainfrom
staging/ad7405-dt
Oct 15, 2026
Merged

nunojsa merged 2 commits into
mainfrom
staging/ad7405-dt

Conversation

@jonathanns

Copy link
Copy Markdown
Contributor

PR Description

Add missing devicetrees for ad7405 And ADuM7701 devices

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@nunojsa nunojsa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please take care to comply to the git subject style. A bit cumbersome to have to repeat this constantly 😅

* Link: https://github.com/analogdevicesinc/hdl/tree/main/projects/ad7405_fmc
* board_revision: <>
*
* Copyright (C) 2025 Analog Devices Inc.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2026

PIoandan and others added 2 commits October 13, 2026 21:41
Enable using the AD7405 device on ZedBoard with FMC connector.

Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
Co-developed-by: Jonathan Santos <Jonathan.Santos@analog.com>
Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
Enable using the ADuM7701-8 device on ZedBoard with FMC connector.

Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
@jonathanns

Copy link
Copy Markdown
Contributor Author

Changes in v2:

  • Fix subject prefix to "arm: dts: xilinx:" and mention the board (ZedBoard)
  • Drop "0x" from the axi-adc backend unit address
  • Fix indentation inside the fpga-axi node
  • Drop empty board_revision tag from the header comment
  • Drop unneeded #address-cells/#size-cells from the ADC node (not allowed
    by the binding, additionalProperties: false)
  • Drop redundant status = "okay" from the fixed regulators.
  • Fix clocks phandles: axi_clk_gen has #clock-cells = <0>, so use
    <&axi_clk_gen> instead of <&axi_clk_gen 0> (dt validate error)
  • addressed other minor issues.

@nunojsa nunojsa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wrong subject... Hint: run git log --oneline --no-merges on the arm dts path (on an upstream tree or disregard our own commits)

@nunojsa
nunojsa merged commit b4561e3 into main Oct 15, 2026
20 of 21 checks passed
@nunojsa
nunojsa deleted the staging/ad7405-dt branch October 15, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants