Skip to content

fix: correct Apache Derby group ID in purl generation #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ankush-Pathak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct Apache Derby group ID in purl generation #5090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions syft/pkg/cataloger/internal/cpegenerate/java_groupid_map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,12 @@ var DefaultArtifactIDToGroupID = map[string]string{
"bcutil-jdk15to18": "org.bouncycastle",
"bcutil-jdk18on": "org.bouncycastle",
"bcutil-lts8on": "org.bouncycastle",
"derby": "org.apache.derby",
"derbyclient": "org.apache.derby",
"derbynet": "org.apache.derby",
"derbyoptionaltools": "org.apache.derby",
"derbyshared": "org.apache.derby",
"derbytools": "org.apache.derby",
"elasticsearch": "org.elasticsearch",
"elasticsearch-analysis-icu": "org.elasticsearch",
"elasticsearch-analysis-ik": "org.elasticsearch",
Expand Down
16 changes: 16 additions & 0 deletions syft/pkg/cataloger/java/package_url_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,22 @@ func Test_groupIDFromJavaMetadata(t *testing.T) {
metadata: pkg.JavaArchive{},
expect: "org.springframework.ldap",
},
{
// regression: Apache Derby jars are OSGi bundles that ship no pom
// metadata, so the manifest heuristic would otherwise pick up
// Bundle-Activator (org.apache.derby.osgi.EmbeddedActivator) as the
// group ID. The known package list must win instead.
name: "known package list derby",
pkgName: "derby",
metadata: pkg.JavaArchive{},
expect: "org.apache.derby",
},
{
name: "known package list derbytools",
pkgName: "derbytools",
metadata: pkg.JavaArchive{},
expect: "org.apache.derby",
},
{
name: "java manifest",
metadata: pkg.JavaArchive{
Expand Down