fix(cyclonedx): preserve metadata.component name and version on decode - #5104
Open
jatinder14 wants to merge 2 commits into
Open
fix(cyclonedx): preserve metadata.component name and version on decode#5104jatinder14 wants to merge 2 commits into
jatinder14 wants to merge 2 commits into
Conversation
extractComponents dropped Name/Version for application (and other non-container/file) components, and omitted them for container/file types as well. That caused metadata.component.version to disappear when Grype re-emitted a CycloneDX SBOM produced with syft --source-version. Closes anchore/grype#2418 Signed-off-by: Jatinder Mahajan <jatinder14122000@gmail.com>
jatinder14
force-pushed
the
fix/cyclonedx-preserve-component-version
branch
from
July 25, 2026 17:20
fcc9819 to
14b5e91
Compare
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
spiffcs
reviewed
Jul 29, 2026
spiffcs
left a comment
spiffcs
left a comment
Contributor
There was a problem hiding this comment.
👋 Thanks for the PR @jatinder14
I pushed a few changes to the tests and added a couple cases that cover the new default path where we assert that name/version/supplier all flow through and are not dropped.
I'll wait for CI to pass here and then 🟢 or ask someone on @anchore/tools for a second pair of 👀.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractComponentsnow always copiesmetadata.componentname/versionintosource.DescriptionMetadata, and containers keepManifestDigestfrom the component versionFixes anchore/grype#2418
Previously, decoding a CycloneDX SBOM (e.g. from
syft . --source-version=0.1.0) droppedmetadata.component.version, sogrype sbom:... --output cyclonedx-jsonemitted an SBOM without that field.Test plan
go test ./syft/format/internal/cyclonedxutil/helpers/ -run Test_extractComponents_preservesNameAndVersionsyft . --output cyclonedx-json=bom.cdx.json --source-version=0.1.0then scan with Grype cyclonedx-json output and confirmmetadata.component.versionis retained (once Grype picks up this Syft fix)