Repository navigation
Update compact-lookups ingest-safety note after profile removal - #69
Merged
Merged
Conversation
The inert async_insert profile block in ops/production/clickhouse/config.xml was removed in #68, so the doc no longer points at it. Async inserts are simply not configured; the default user runs with stock settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Ingest safety" section of `docs/preview_compact_lookups.md` (from #67) says the `async_insert` profile settings in `ops/production/clickhouse/config.xml` are not in effect. #68 deleted that block, so the sentence now points at something that does not exist.
Fix
Say what is true now: async inserts are not configured, and the `default` user runs with stock settings, as documented in `users.xml`. The rest of the section still holds. A failing view fails the INSERT, the segment is retried and then queued for reindexing, and enabling async inserts with `wait_for_async_insert=0` would make failures drop rows silently.
Docs only. `just precommit` passes.
🤖 Generated with Claude Code